Skip to content

Add AMD GPU support for DeepSeek-V3.2-Exp (MI300X/MI325X/MI355X + AITER)#279

Open
GoldenGrapeGentleman wants to merge 1 commit intovllm-project:mainfrom
GoldenGrapeGentleman:amd-deepseek-v3-2-exp
Open

Add AMD GPU support for DeepSeek-V3.2-Exp (MI300X/MI325X/MI355X + AITER)#279
GoldenGrapeGentleman wants to merge 1 commit intovllm-project:mainfrom
GoldenGrapeGentleman:amd-deepseek-v3-2-exp

Conversation

@GoldenGrapeGentleman
Copy link
Copy Markdown

Summary

This PR adds AMD GPU support for DeepSeek-V3.2-Exp on MI300X/MI325X/MI355X GPUs.

Changes

  • Step 1: uv-based vLLM ROCm installation guide
  • Step 2: vLLM server launch command with AITER and AITER_MOE enabled
    • --block-size 1 required for ROCm Sparse MLA attention
    • --kv-cache-dtype bfloat16 for better latency on short requests
    • --max-num-batched-tokens 32768 for throughput optimization
  • Step 3: Benchmark script

Hardware Tested

Hardware Status
8x AMD MI300X + AITER ✅ Verified
8x AMD MI355X + AITER ✅ Verified

Related

Closes the AMD GPU support gap originally started in #143.

- Add Step 1: uv-based vLLM ROCm installation
- Add Step 2: vLLM server startup with AITER and AITER_MOE enabled
  - Use --block-size 1 required for ROCm Sparse MLA
  - Set --kv-cache-dtype bfloat16 for better latency
  - Set --max-num-batched-tokens 32768 for throughput
- Add Step 3: benchmark script

Tested and verified on 8x AMD MI300X and 8x AMD MI355X GPUs with AITER.

Signed-off-by: Yuan Yue <yueyuan@amd.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the DeepSeek-V3.2-Exp model's accessibility by integrating official support for AMD MI300X/MI325X/MI355X GPUs. It provides users with a clear, verified pathway to deploy and benchmark the model on AMD hardware, addressing a critical compatibility gap and expanding the model's operational environment.

Highlights

  • AMD GPU Support: Added comprehensive instructions for running DeepSeek-V3.2-Exp models on AMD MI300X/MI325X/MI355X GPUs.
  • vLLM ROCm Installation: Provided a step-by-step guide for installing vLLM with ROCm backend using 'uv' for AMD GPUs.
  • vLLM Server Configuration: Included a sample command for launching the vLLM server with specific parameters like '--block-size 1', '--kv-cache-dtype bfloat16', and '--max-num-batched-tokens 32768' for optimal performance on AMD hardware with AITER enabled.
  • Benchmarking Script: Introduced a command to run a benchmark script for evaluating the performance of DeepSeek-V3.2-Exp on AMD GPUs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • DeepSeek/DeepSeek-V3_2-Exp.md
    • Added a new top-level section "AMD GPU Support".
    • Included "Step 1: Installing vLLM (AMD ROCm Backend: MI300X, MI325X, MI355X)" with 'uv' installation commands.
    • Provided "Step 2: Start the vLLM server" with a detailed 'vllm serve' command.
    • Added "Step 3: Run Benchmark" with a 'vllm bench serve' command.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for running DeepSeek-V3.2-Exp on AMD GPUs. The new section in DeepSeek-V3_2-Exp.md provides clear instructions for installation, server launch, and benchmarking. My review includes a suggestion to improve the conciseness of the introductory text for better readability.

Comment on lines +90 to +94
Recommended approaches by hardware type are:

MI300X/MI325X/MI355X

Please follow the steps here to install and run DeepSeek-V3.2-Exp models on AMD MI300X/MI325X/MI355X GPU.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The introductory text for the AMD GPU support section is a bit repetitive and could be more concise. Consider rephrasing to improve readability.

Suggested change
Recommended approaches by hardware type are:
MI300X/MI325X/MI355X
Please follow the steps here to install and run DeepSeek-V3.2-Exp models on AMD MI300X/MI325X/MI355X GPU.
This section provides instructions for running DeepSeek-V3.2-Exp on AMD MI300X, MI325X, and MI355X GPUs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant