Add AMD GPU support for DeepSeek-V3.1 (MI300X/MI325X/MI355X + AITER)#277
Add AMD GPU support for DeepSeek-V3.1 (MI300X/MI325X/MI355X + AITER)#277GoldenGrapeGentleman wants to merge 1 commit intovllm-project:mainfrom
Conversation
- Add Step 1: uv-based vLLM ROCm installation - Add Step 2: vLLM server startup with AITER and AITER_MOE enabled - Add Step 3: benchmark script Tested and verified on 8x AMD MI300X and 8x AMD MI355X GPUs with AITER. Signed-off-by: Yuan Yue <yueyuan@amd.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the DeepSeek-V3.1 documentation by integrating full support for AMD GPUs, specifically the MI300X, MI325X, and MI355X series. It provides users with a clear, step-by-step guide for setting up the vLLM environment, launching the server with optimized configurations for AMD hardware, and performing benchmarks, thereby broadening the accessibility and performance capabilities of DeepSeek-V3.1 on AMD platforms. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds valuable documentation for running DeepSeek-V3.1 on AMD GPUs. The instructions are clear and cover installation, server launch, and benchmarking. I've found one issue with the benchmark command which is incorrect and will prevent users from running it. I've suggested a fix for it. I also noticed that other documentation files in the repository use the same incorrect vllm bench serve command. It would be beneficial to correct these in a separate effort to maintain consistency and accuracy across all documentation. Otherwise, the changes in this PR look good.
| vllm bench serve \ | ||
| --model deepseek-ai/DeepSeek-V3.1 \ | ||
| --dataset-name random \ | ||
| --random-input-len 8192 \ | ||
| --random-output-len 1024 \ | ||
| --request-rate 10000 \ | ||
| --num-prompts 16 \ | ||
| --ignore-eos \ | ||
| --trust-remote-code |
There was a problem hiding this comment.
The vllm bench serve command appears to be incorrect. The correct command to run the vLLM benchmark is vllm benchmark. The arguments provided are valid for the vllm benchmark command.
| vllm bench serve \ | |
| --model deepseek-ai/DeepSeek-V3.1 \ | |
| --dataset-name random \ | |
| --random-input-len 8192 \ | |
| --random-output-len 1024 \ | |
| --request-rate 10000 \ | |
| --num-prompts 16 \ | |
| --ignore-eos \ | |
| --trust-remote-code | |
| vllm benchmark \ | |
| --model deepseek-ai/DeepSeek-V3.1 \ | |
| --dataset-name random \ | |
| --random-input-len 8192 \ | |
| --random-output-len 1024 \ | |
| --request-rate 10000 \ | |
| --num-prompts 16 \ | |
| --ignore-eos \ | |
| --trust-remote-code |
Summary
This PR adds AMD GPU support for DeepSeek-V3.1 on MI300X/MI325X/MI355X GPUs.
Changes
Hardware Tested
Related
Closes the AMD GPU support gap originally started in #158.