Add FP8 B200 best config to MiniMax-M2.5 recipe#272
Add FP8 B200 best config to MiniMax-M2.5 recipe#272faradawn wants to merge 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
03ac3aa to
284460c
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the MiniMax-M2.5 recipe by incorporating a new configuration tailored for FP8 serving on B200 GPUs. This update expands the hardware compatibility for deploying the model, providing optimized launch instructions for users leveraging B200 hardware and ensuring efficient model execution. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively adds the FP8 B200 best configuration to the MiniMax-M2.5 recipe documentation. The new instructions are clear and provide valuable guidance for users leveraging B200 GPUs. The overall structure of the updated section is good, making it easy to follow the different deployment options.
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
| For 2x B200: FP8 serving on B200 GPUs with FlashInfer MoE FP8 and DeepGEMM MoE disabled: | ||
|
|
||
| ```bash | ||
| export VLLM_USE_FLASHINFER_MOE_FP8=0 |
There was a problem hiding this comment.
instead of this, can we just update the default oracle in VLLM to select a different kernel for this case?
There was a problem hiding this comment.
this is where the code is to update the priority order
There was a problem hiding this comment.
Hi @robertgshaw2-redhat, thank you for the comment! Can you check if this PR addresses your comment: vllm-project/vllm#37056
Summary
Adds FP8 serving config fo B200 GPUs to the MiniMax-M2.5 recipe
Reference: SemiAnalysisAI/InferenceX#757