Add per-IP rate limiting to prevent DoS attacks#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds in-memory sliding-window rate limiting to all upload, processing, read, and retention endpoints, mitigating denial-of-service attacks by throttling excessive requests per client IP. Returns HTTP 429 (Too Many Requests) when limits are exceeded.
Motivation
Upload and processing endpoints were previously unprotected against request flooding. A single client could exhaust server resources (CPU, DB connections, disk I/O, bandwidth) by sending unbounded requests. Read endpoints (
GET) are also vulnerable to connection pool and bandwidth exhaustion.Changes
RateLimiterclass: thread-safe sliding-window limiter keyed by client IP (X-Forwarded-Foror socket address)IMG_env var prefixupload_rate_limiter(),process_rate_limiter(),read_rate_limiter()DI factoriesX-Forwarded-Forparsing1.2.3→1.2.4[1.2.4]Security entryDefault rate limits
POST /images/)IMG_RATE_LIMIT_UPLOAD_MAX,IMG_RATE_LIMIT_UPLOAD_WINDOWPOST /*/process,/retention/sweep)IMG_RATE_LIMIT_PROCESS_MAX,IMG_RATE_LIMIT_PROCESS_WINDOWGET /images/*)IMG_RATE_LIMIT_READ_MAX,IMG_RATE_LIMIT_READ_WINDOWDesign decisions
X-Forwarded-Forsupport — Uses the first IP in the chain for correctness behind reverse proxies.threading.Locksince FastAPI may run dependencies in thread pool.Verification