Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again!
I noticed that on Flathub and in app stores, the description falls back to English instead of being localized to Czech. There was nothing wrong with the translation, so I checked the validation of the metainfo file and the commit history.
Validation (before fix)
appstreamcli validate --pedantic com.vkhitrin.cosmicding.metainfo.xml I: com.vkhitrin.cosmicding:21: description-first-para-too-short A client to manage your bookmarks. E: com.vkhitrin.cosmicding:30: description-enum-item-invalid ul I: com.vkhitrin.cosmicding:130: relation-control-in-requires I: com.vkhitrin.cosmicding:131: relation-control-in-requires ✘ Validation failed: errors: 1, infos: 3The validator complains that there is an invalid
ulelement inside the description. You removed that in commit c446b8e, but then your changes got overwritten later in 5ed5dd3I fixed the metainfo validation (based on your commit c446b8e). I'm not sure whether this will fix the localization problem, but it should as there is absolutely no other reason
Validation (after fix)
appstreamcli validate --pedantic com.vkhitrin.cosmicding.metainfo.xml I: com.vkhitrin.cosmicding:21: description-first-para-too-short A client to manage your bookmarks. I: com.vkhitrin.cosmicding:128: relation-control-in-requires I: com.vkhitrin.cosmicding:129: relation-control-in-requires ✔ Validation was successful: infos: 3Additionally