chore(deps): update dependency undici to v5 [security]#144
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
chore(deps): update dependency undici to v5 [security]#144renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
8d3a4d8 to
d442404
Compare
d442404 to
a2eb75f
Compare
a2eb75f to
a400da4
Compare
a400da4 to
fa044c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^4.12.1→^5.0.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
ProxyAgent vulnerable to MITM
CVE-2022-32210 / GHSA-pgw7-wx7w-2w33
More information
Details
Description
Undici.ProxyAgentnever verifies the remote server's certificate, and always exposes all request & response data to the proxy. This unexpectedly means that proxies can MitM all HTTPS traffic, and if the proxy's URL is HTTP then it also means that nominally HTTPS requests are actually sent via plain-text HTTP between Undici and the proxy server.Impact
This affects all use of HTTPS via HTTP proxy using
Undici.ProxyAgentwith Undici or Node's globalfetch. In this case, it removes all HTTPS security from all requests sent using Undici'sProxyAgent, allowing trivial MitM attacks by anybody on the network path between the client and the target server (local network users, your ISP, the proxy, the target server's ISP, etc).This less seriously affects HTTPS via HTTPS proxies. When you send HTTPS via a proxy to a remote server, the proxy can freely view or modify all HTTPS traffic unexpectedly (but only the proxy).
Patches
This issue was patched in Undici v5.5.1.
Workarounds
At the time of writing, the only workaround is to not use
ProxyAgentas a dispatcher for TLS Connections.Severity
CVSS:3.1/AV:N/AC:H/PR:H/UI:N/S:C/C:H/I:H/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
undici before v5.8.0 vulnerable to CRLF injection in request headers
CVE-2022-31150 / GHSA-3cvr-822r-rqcc
More information
Details
Impact
It is possible to inject CRLF sequences into request headers in Undici.
The same applies to
pathandmethodPatches
Update to v5.8.0
Workarounds
Sanitize all HTTP headers from untrusted sources to eliminate
\r\n.References
https://hackerone.com/reports/409943
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-12116
For more information
If you have any questions or comments about this advisory:
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
undici before v5.8.0 vulnerable to uncleared cookies on cross-host / cross-origin redirect
CVE-2022-31151 / GHSA-q768-x9m6-m9qp
More information
Details
Impact
Authorization headers are already cleared on cross-origin redirect in
https://github.com/nodejs/undici/blob/main/lib/handler/redirect.js#L189, based on https://github.com/nodejs/undici/issues/872.
However, cookie headers which are sensitive headers and are official headers found in the spec, remain uncleared. There also has been active discussion of implementing a cookie store https://github.com/nodejs/undici/pull/1441, which suggests that there are active users using cookie headers in undici.
As such this may lead to accidental leakage of cookie to a 3rd-party site or a malicious attacker who can control the redirection target (ie. an open redirector) to leak the cookie to the 3rd party site.
Patches
This was patched in v5.8.0.
Workarounds
By default, this vulnerability is not exploitable.
Do not enable redirections, i.e.
maxRedirections: 0(the default).References
https://hackerone.com/reports/1635514
https://curl.se/docs/CVE-2018-1000007.html
https://curl.se/docs/CVE-2022-27776.html
For more information
If you have any questions or comments about this advisory:
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
undici.requestvulnerable to SSRF using absolute URL onpathnameCVE-2022-35949 / GHSA-8qr4-xgw6-wmr3
More information
Details
Impact
undiciis vulnerable to SSRF (Server-side Request Forgery) when an application takes in user input into thepath/pathnameoption ofundici.request.If a user specifies a URL such as
http://127.0.0.1or//127.0.0.1Instead of processing the request as
http://example.org//127.0.0.1(orhttp://example.org/http://127.0.0.1whenhttp://127.0.0.1 is used), it actually processes the request ashttp://127.0.0.1/and sends it tohttp://127.0.0.1.If a developer passes in user input into
pathparameter ofundici.request, it can result in an SSRF as they will assume that the hostname cannot change, when in actual fact it can change because the specified path parameter is combined with the base URL.Patches
This issue was fixed in
undici@5.8.1.Workarounds
The best workaround is to validate user input before passing it to the
undici.requestcall.For more information
If you have any questions or comments about this advisory:
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Nodejs ‘undici’ vulnerable to CRLF Injection via Content-Type
CVE-2022-35948 / GHSA-f772-66g8-q5h3
More information
Details
Impact
=< undici@5.8.0users are vulnerable to CRLF Injection on headers when using unsanitized input as request headers, more specifically, inside thecontent-typeheader.Example:
The above snippet will perform two requests in a single
requestAPI call:http://localhost:3000/http://localhost:3000/foo2Patches
This issue was patched in Undici v5.8.1
Workarounds
Sanitize input when sending content-type headers using user input.
For more information
If you have any questions or comments about this advisory:
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
CRLF Injection in Nodejs ‘undici’ via host
CVE-2023-23936 / GHSA-5r9g-qh6m-jxff
More information
Details
Impact
undici library does not protect
hostHTTP header from CRLF injection vulnerabilities.Patches
This issue was patched in Undici v5.19.1.
Workarounds
Sanitize the
headers.hoststring before passing to undici.References
Reported at https://hackerone.com/reports/1820955.
Credits
Thank you to Zhipeng Zhang (@timon8) for reporting this vulnerability.
Severity
CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Regular Expression Denial of Service in Headers
CVE-2023-24807 / GHSA-r6ch-mqf9-qc9w
More information
Details
Impact
The
Headers.set()andHeaders.append()methods are vulnerable to Regular Expression Denial of Service (ReDoS) attacks when untrusted values are passed into the functions. This is due to the inefficient regular expression used to normalize the values in theheaderValueNormalize()utility function.Patches
This vulnerability was patched in v5.19.1.
Workarounds
There is no workaround. Please update to an unaffected version.
References
Credits
Carter Snook reported this vulnerability.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:HReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Undici's cookie header not cleared on cross-origin redirect in fetch
CVE-2023-45143 / GHSA-wqq4-5wpv-mx2g
More information
Details
Impact
Undici clears Authorization headers on cross-origin redirects, but does not clear
Cookieheaders. By design,cookieheaders are forbidden request headers, disallowing them to be set inRequestInit.headersin browser environments. Since Undici handles headers more liberally than the specification, there was a disconnect from the assumptions the spec made, and Undici's implementation of fetch.As such this may lead to accidental leakage of cookie to a 3rd-party site or a malicious attacker who can control the redirection target (ie. an open redirector) to leak the cookie to the 3rd party site.
Patches
This was patched in e041de359221ebeae04c469e8aff4145764e6d76, which is included in version 5.26.2.
Severity
CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:U/C:L/I:L/A:LReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Undici proxy-authorization header not cleared on cross-origin redirect in fetch
CVE-2024-24758 / GHSA-3787-6prv-h9w3
More information
Details
Impact
Undici already cleared Authorization headers on cross-origin redirects, but did not clear
Proxy-Authorizationheaders.Patches
This is patched in v5.28.3 and v6.6.1
Workarounds
There are no known workarounds.
References
Severity
CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:U/C:L/I:L/A:LReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Undici's Proxy-Authorization header not cleared on cross-origin redirect for dispatch, request, stream, pipeline
CVE-2024-30260 / GHSA-m4v8-wqvr-p9f7
More information
Details
Impact
Undici cleared Authorization and Proxy-Authorization headers for
fetch(), but did not clear them forundici.request().Patches
This has been patched in nodejs/undici@6805746.
Fixes has been released in v5.28.4 and v6.11.1.
Workarounds
use
fetch()or disablemaxRedirections.References
Linzi Shang reported this.
Severity
CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:U/C:L/I:L/A:LReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Undici's fetch with integrity option is too lax when algorithm is specified but hash value is in incorrect
CVE-2024-30261 / GHSA-9qxr-qj54-h672
More information
Details
Impact
If an attacker can alter the
integrityoption passed tofetch(), they can letfetch()accept requests as valid even if they have been tampered.Patches
Fixed in nodejs/undici@d542b8c.
Fixes has been released in v5.28.4 and v6.11.1.
Workarounds
Ensure that
integritycannot be tampered with.References
https://hackerone.com/reports/2377760
Severity
CVSS:3.1/AV:N/AC:H/PR:L/UI:R/S:U/C:N/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
nodejs/undici (undici)
v5.28.4Compare Source
Full Changelog: nodejs/undici@v5.28.3...v5.28.4
v5.28.3Compare Source
Fixes:
Full Changelog: nodejs/undici@v5.28.2...v5.28.3
v5.28.2Compare Source
What's Changed
node:prefix by @tsctx in #2471nulltype tosignalinRequestInitby @gebsh in #2455New Contributors
Full Changelog: nodejs/undici@v5.28.1...v5.28.2
v5.28.1Compare Source
What's Changed
normalizeMethodby @tsctx in #2456Full Changelog: nodejs/undici@v5.28.0...v5.28.1
v5.28.0Compare Source
What's Changed
substringinstead ofsubstrby @tsctx in #2411Headers#setcorrectly by @tsctx in #2432Headers#deletecorrectly by @tsctx in #2430onHeaderstype declaration by @tsctx in #2444pathmatching inintercept()by @oliversalzburg in #2426New Contributors
Full Changelog: nodejs/undici@v5.27.2...v5.28.0
v5.27.2Compare Source
Full Changelog: nodejs/undici@v5.27.1...v5.27.2
v5.27.1Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.27.0...v5.27.1
v5.27.0Compare Source
What's Changed
Full Changelog: nodejs/undici@v5.26.5...v5.27.0
v5.26.5Compare Source
What's Changed
Full Changelog: nodejs/undici@v5.26.4...v5.26.5
v5.26.4Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.26.3...v5.26.4
v5.26.3Compare Source
v5.26.2Compare Source
Security Release, CVE-2023-45143.
v5.26.1Compare Source
What's Changed
Full Changelog: nodejs/undici@v5.26.0...v5.26.1
v5.26.0Compare Source
What's Changed
nodeby @Ethan-Arrowood in #2310--max-http-header-sizeNode.js flag by @balazsorban44 in #2234New Contributors
Full Changelog: nodejs/undici@v5.23.4...v5.26.0
v5.25.4Compare Source
v5.25.3Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.25.2...v5.25.3
v5.25.2Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.25.1...v5.25.2
v5.25.1Compare Source
What's Changed
Full Changelog: nodejs/undici@v5.25.0...v5.25.1
v5.25.0Compare Source
What's Changed
New Contributors
Full Changelog: nodejs/undici@v5.24.0...v5.25.0
v5.24.0Compare Source
Notable Changes
What's Changed
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.