fix: resolve test compilation errors and update tests for PDF support#52
Merged
Merged
Conversation
- Add missing downloadFileBytes() override to FakeGoogleDriveApiClient - Fix BaseResumeContentResponse constructor call missing readOnly argument - Update PDF rejection tests to use unsupported MIME type (docx) since PDFs are now accepted as read-only resumes - Fix McpAuthIT setUp by deleting google_drive_connections before users to avoid FK constraint violation https://claude.ai/code/session_01WsXBePpMyKd57McmFAyyTQ
Qodana for JVM3 new problems were found
View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Summary
FakeGoogleDriveApiClientwas missing thedownloadFileBytes(String, String)override required by theGoogleDriveApiClientinterfaceBaseResumeContentResponseconstructor inMcpResumeContentResourcesTestwas missing the newreadOnlyboolean argument (record now has 6 fields)addBaseResume_shouldRejectNonGoogleDocsFile(s)tests were still asserting PDFs are rejected, but production code was updated to accept PDFs as read-only resumes — updated tests to use an unsupported MIME type (application/vnd.openxmlformats-officedocument.wordprocessingml.document) insteadMcpAuthIT.setUpwas throwing aDataIntegrityViolationwhen callinguserRepository.deleteAll()because leftovergoogle_drive_connectionsrecords (FK to users) were not cleaned up — addedgoogleDriveConnectionRepository.deleteAll()before deleting usersTest plan
mvn clean verifypasses with 0 failures, 0 errorsGoogleDriveControllerIT— all tests greenGoogleDriveServiceTest— all tests greenMcpResumeContentResourcesTest— all tests greenMcpAuthIT— all 4 tests greenhttps://claude.ai/code/session_01WsXBePpMyKd57McmFAyyTQ
EOF
)
Generated by Claude Code