Skip to content

fix: resolve test compilation errors and update tests for PDF support#52

Merged
vitorhugo-java merged 1 commit into
mainfrom
claude/job-tracker-test-compilation-vDCp6
Jun 6, 2026
Merged

fix: resolve test compilation errors and update tests for PDF support#52
vitorhugo-java merged 1 commit into
mainfrom
claude/job-tracker-test-compilation-vDCp6

Conversation

@vitorhugo-java

Copy link
Copy Markdown
Owner

$(cat <<'EOF'

Summary

  • Fix compilation error: FakeGoogleDriveApiClient was missing the downloadFileBytes(String, String) override required by the GoogleDriveApiClient interface
  • Fix compilation error: BaseResumeContentResponse constructor in McpResumeContentResourcesTest was missing the new readOnly boolean argument (record now has 6 fields)
  • Fix failing tests: addBaseResume_shouldRejectNonGoogleDocsFile(s) tests were still asserting PDFs are rejected, but production code was updated to accept PDFs as read-only resumes — updated tests to use an unsupported MIME type (application/vnd.openxmlformats-officedocument.wordprocessingml.document) instead
  • Fix failing tests: McpAuthIT.setUp was throwing a DataIntegrityViolation when calling userRepository.deleteAll() because leftover google_drive_connections records (FK to users) were not cleaned up — added googleDriveConnectionRepository.deleteAll() before deleting users

Test plan

  • mvn clean verify passes with 0 failures, 0 errors
  • GoogleDriveControllerIT — all tests green
  • GoogleDriveServiceTest — all tests green
  • McpResumeContentResourcesTest — all tests green
  • McpAuthIT — all 4 tests green

https://claude.ai/code/session_01WsXBePpMyKd57McmFAyyTQ
EOF
)


Generated by Claude Code

- Add missing downloadFileBytes() override to FakeGoogleDriveApiClient
- Fix BaseResumeContentResponse constructor call missing readOnly argument
- Update PDF rejection tests to use unsupported MIME type (docx) since PDFs are now accepted as read-only resumes
- Fix McpAuthIT setUp by deleting google_drive_connections before users to avoid FK constraint violation

https://claude.ai/code/session_01WsXBePpMyKd57McmFAyyTQ
@github-actions github-actions Bot added the tests label Jun 6, 2026
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

Qodana for JVM

3 new problems were found

Inspection name Severity Problems
Nullability and data flow problems 🔶 Warning 1
Mismatched query and update of 'StringBuilder' 🔶 Warning 1
Simplifiable conditional expression 🔶 Warning 1
View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.3.2
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@vitorhugo-java vitorhugo-java merged commit ef815fb into main Jun 6, 2026
6 checks passed
@vitorhugo-java vitorhugo-java deleted the claude/job-tracker-test-compilation-vDCp6 branch June 6, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants