Skip to content

Update operator CRDs to include extraLabels#19794

Open
jdoupe wants to merge 1 commit intovitessio:mainfrom
jdoupe:add-extra-labels
Open

Update operator CRDs to include extraLabels#19794
jdoupe wants to merge 1 commit intovitessio:mainfrom
jdoupe:add-extra-labels

Conversation

@jdoupe
Copy link
Copy Markdown
Contributor

@jdoupe jdoupe commented Apr 4, 2026

Description

This brings in the CRD changes to vitess-operator branch of the same name.
planetscale/vitess-operator#735

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Signed-off-by: Jeremy Doupe <jeremy@doupe.com>
@jdoupe jdoupe requested review from frouioui and mattlord as code owners April 4, 2026 18:07
Copilot AI review requested due to automatic review settings April 4, 2026 18:07
@github-actions github-actions bot added this to the v24.0.0 milestone Apr 4, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 4, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Apr 4, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@promptless
Copy link
Copy Markdown
Contributor

promptless bot commented Apr 4, 2026

Promptless prepared a documentation update related to this change.

Triggered by vitessio/vitess#19794

Added documentation for the new extraLabels feature in operator CRDs, explaining how users can add custom Kubernetes labels to backup-related resources including VitessBackupSchedule, VitessBackupStorage, and VitessCluster backup pods.

Review at https://app.gopromptless.ai/suggestions/1f266a6f-6d9e-4f3c-8c93-ee4ac1870a37

@mattlord mattlord modified the milestones: v24.0.0, v25.0.0 Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Examples NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants