Update install-vitasdk.sh to check for arch on Linux#107
Open
joel16 wants to merge 1 commit intovitasdk:masterfrom
Open
Update install-vitasdk.sh to check for arch on Linux#107joel16 wants to merge 1 commit intovitasdk:masterfrom
joel16 wants to merge 1 commit intovitasdk:masterfrom
Conversation
d3m3vilurr
reviewed
Mar 11, 2025
| if [ "$(uname -m)" == "aarch64" ]; then | ||
| wget -O- "$(get_download_link master linux-arm64)" | tar xj -C $INSTALLDIR --strip-components=1 | ||
| else | ||
| wget -O- "$(get_download_link master linux)" | tar xj -C $INSTALLDIR --strip-components=1 |
Contributor
There was a problem hiding this comment.
I remember that when I first read this patch, I'm worried that a script can download aarch64 version on linux x86_64
so, safe way is, we should split type linux-arm64 and linux-x86_64.
but for backward compatibility, it should be.. linux-v2 (cuz a tag would be master-linux-v2.4321)
Suggested change
| wget -O- "$(get_download_link master linux)" | tar xj -C $INSTALLDIR --strip-components=1 | |
| wget -O- "$(get_download_link master linux-v2)" | tar xj -C $INSTALLDIR --strip-components=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If aarch64 is being used, the script will atempt to download the arm64 version, otherwise it will default to x86_64 or other architectures.
FYI: I have added support for linux-arm64 (vitasdk/autobuilds#23)