DFM-4544: Migrate to SDLC standards (UV + sdlc@3 + codeartifact@3)#56
Closed
franciscofabian wants to merge 5 commits into
Closed
DFM-4544: Migrate to SDLC standards (UV + sdlc@3 + codeartifact@3)#56franciscofabian wants to merge 5 commits into
franciscofabian wants to merge 5 commits into
Conversation
- Convert setup.py/setup.cfg + partial pyproject.toml to PEP 621 pyproject.toml - Pin parquery==2.0.6 (matched setup.py; pyproject had stale 2.0.2) - Drop pyarrow direct dep (pulled transitively via parquery) - Drop codacy-coverage from test deps - Add uv.lock with CodeArtifact private index - __version__ via importlib.metadata - CircleCI: sdlc@3 + codeartifact@3, run-tests-with-coverage with --ignore for test_move_parquet.py + test_simple_rpc.py, PARQUERYD_DATA_DIR=/tmp/parquet/ env setup, publish-rc on master/main, approval-gated create-release-branch, publish-release on release/*, opt-in publish-dev on feature branches - Pre-commit hooks (ADR-4): ruff, bandit, branch-name, uv-lock - ruff config moved from pyproject.toml to standalone ruff.toml - .github/workflows: validate-pr + pr-jira-footer - .coveragerc, Makefile (kebab-case, help target)
Collaborator
Coverage Report
Compare branch: Changed file coverage
|
--- jira: DFM-4544
Per review on parquery PR #46: Python packages don't need release-candidate or release-branch indirection. Every merge to main publishes a full timestamp-versioned package + GitHub release, mirroring the odin-shared-package pattern. --- jira: DFM-4544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.py/setup.cfg(and the partial pyproject.toml) to a full PEP 621pyproject.tomlparquery==2.0.6(setup.pyhad2.0.6, the partial pyproject had stale2.0.2)pyarrowdep (pulled transitively viaparquery)codacy-coveragefrom the test group (replaced bysdlc/run-tests-with-coverage)uv.lock(65 packages resolved against CodeArtifact private index)__version__now resolved viaimportlib.metadata(drops thePRE_RELEASE_VERSIONenv-var fallback)sdlc@3+codeartifact@3orbs; full SDLC flow:test→ approval →publish-dev(X.Y.Z.devN)test→publish-rc(X.Y.ZrcN) → approval →create-release-branchtest→publish-release(X.Y.TIMESTAMP) +create-git-releasesdlc/run-tests-with-coveragepreserves the existing test exclusions (test_move_parquet.py,test_simple_rpc.py) viaextra-pytest-args, setsPARQUERYD_DATA_DIR=/tmp/parquet/before runningruff,bandit,uv-lockauto-updateruffconfig moved frompyproject.toml→ standaloneruff.toml(per ADR-4).coveragerc,Makefile(kebab-case targets + defaulthelptarget)Verification
uv lockresolves cleanly (65 packages)uv buildproduces wheel + sdistcircleci config validatepassesmake helpprints the target listNotes
2.0.2rc1(latest published is2.0.1, no timestamp). After the firstpublish-releaseon a release branch publishes a timestamp version, subsequent rc/dev versions will inherit the timestamp.Test plan
testjob runs and passes on this PR (the two known-flaky tests are still ignored)master:publish-rcpublishes2.0.2rc1to CodeArtifactcreate-release-branchpublish-releasepublishes the timestamped final + GH release with assetsjira: DFM-4544