DFM-4544: Migrate to SDLC standards (UV + sdlc@3 + codeartifact@3)#46
Merged
Conversation
- Convert setup.py/setup.cfg to PEP 621 pyproject.toml - Add uv.lock with CodeArtifact private index (remove from .gitignore) - __version__ via importlib.metadata - CircleCI: sdlc@3 + codeartifact@3, run-tests-with-coverage, publish-rc on master/main, approval-gated create-release-branch, publish-release on release/*, opt-in publish-dev on feature branches - Pre-commit hooks (ADR-4): ruff, bandit, branch-name, uv-lock - .github/workflows: validate-pr + pr-jira-footer - .coveragerc, ruff.toml, Makefile (kebab-case targets, help target)
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
ffinkbe
reviewed
May 1, 2026
| - /release\/.*/ | ||
|
|
||
| # Main: publish RC + approval-gated release-branch creation | ||
| - publish-rc: |
Contributor
There was a problem hiding this comment.
I don't think this is correct. Everything merged to main is a full released version. Release branches are only needed if we want to hotfix something for a specific release. But in that case we also want to build a real version not a release candidate.
Per review on PR #46: Python packages don't need release-candidate or release-branch indirection. Every merge to main publishes a full timestamp-versioned package + GitHub release, mirroring the odin-shared-package pattern. --- jira: DFM-4544
Re-add create-release-branch as an opt-in feature-branch approval gate; publish-package now runs on both main and release/* (full timestamp release + GitHub release on either). Mirrors the vf_initialize_data final shape. --- jira: DFM-4544
imartinez-vf
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.py/setup.cfgto PEP 621pyproject.toml(preserves the[build-system].requirespin onpyarrow>=22.0.0and theperformance/dataframes/alloptional-dependency groups)uv.lock(22 packages resolved against CodeArtifact private index) — also removeduv.lockfrom.gitignore__version__now resolved viaimportlib.metadatasdlc@3+codeartifact@3orbs; full SDLC flow:test→ approval →publish-dev(X.Y.Z.devN)test→publish-rc(X.Y.ZrcN) → approval →create-release-branchtest→publish-release(X.Y.TIMESTAMP) +create-git-releaseruff,bandit,uv-lockauto-update.coveragerc,ruff.toml,Makefile(kebab-case targets + defaulthelptarget)Verification
uv lockresolves cleanly (22 packages)uv buildproduces wheel + sdistcircleci config validatepassesmake helpprints the target listTest plan
testjob runs and passes on this PRmaster:publish-rcpublishes2.0.8rc1to CodeArtifactcreate-release-branchpublish-releasepublishes the timestamped final + GH release with assetsjira: DFM-4544