Fix RagService initialization crash, race conditions, and blocking API calls#688
Open
Siddhant2713 wants to merge 3 commits into
Open
Fix RagService initialization crash, race conditions, and blocking API calls#688Siddhant2713 wants to merge 3 commits into
Siddhant2713 wants to merge 3 commits into
Conversation
|
@Siddhant2713 is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple stability and reliability issues affecting
VakilFriendService, particularly startup failures and request handling problems observed in Docker/local deployments.Issues Fixed
1. RagService causing VakilFriendService startup failure
resource.getFile()fails inside Spring Boot fat JAR deployments.AllMiniLmL6V2EmbeddingModel()loads a large ONNX model causing memory pressure in constrained containers.VakilFriendServicedepends directly onRagService, initialization failure propagates and breaks all/api/vakil-friend/*endpoints.2. Session initialization race condition
sendMessage()only checkedisLoading.startSession()completed.3. Raw axios usage without timeout/interceptors
axiosusage with the configured API instance.4. Blocking RestTemplate calls
new RestTemplate()with default infinite timeouts.Root Cause Analysis
The primary failure was caused by
RagServiceinitialization during application startup.This issue reproduces locally in Docker, confirming the problem is not related to Render cold starts.
Impact
Testing