Prevent client-controlled privileged role on registration#629
Open
sathwikhbhat wants to merge 1 commit into
Open
Prevent client-controlled privileged role on registration#629sathwikhbhat wants to merge 1 commit into
sathwikhbhat wants to merge 1 commit into
Conversation
|
@sathwikhbhat is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR tightens role handling during user registration by sanitizing/overriding client-supplied roles and simplifying the role passed into authService.register().
Changes:
- Added server-side override logic to default
roletoLITIGANTwhen missing or invalid. - Removed the inline
req.getRole() != null ? ... : ...defaulting when callingauthService.register().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fix a privilege escalation issue in public registration by preventing clients from choosing privileged backend roles. The register endpoint now treats incoming roles as untrusted and defaults public signups to
LITIGANTrather than allowingADMIN,TECH_ADMIN, or other elevated roles.Closes #628
Type of change
Checklist: