Skip to content

Run tapirx as PID 1 in discovery scenario#10

Draft
t-a-y-l-o-r wants to merge 1 commit into
mainfrom
feature/upsert-migration-tests
Draft

Run tapirx as PID 1 in discovery scenario#10
t-a-y-l-o-r wants to merge 1 commit into
mainfrom
feature/upsert-migration-tests

Conversation

@t-a-y-l-o-r
Copy link
Copy Markdown
Contributor

Summary

  • Remove passive-discovery docker exec anti-pattern — tapirx now runs as PID 1 via its entrypoint
  • Add enable-waffle-switch command (required by new BlueFlow upsert endpoint)
  • Add TAPIRX_UPSERT_URL env var to testbed topology
  • Add tapirx.local.Dockerfile for building from local source

Context

The old scenario ran tapirx via docker exec (detached) into an already-running container. This meant PID 1 was a useless tapirx process with no API URL, the real worker's logs were lost, and two processes competed for packets on the same interface.

Dependencies

Test plan

  • Integration test 3 passes: post-change tapirx + post-change blueflow → 1 asset created

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9e4b7cb9-8f50-46f8-9042-c89e3fafa09f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/upsert-migration-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@t-a-y-l-o-r t-a-y-l-o-r force-pushed the feature/upsert-migration-tests branch 2 times, most recently from 647c351 to 68f6cb3 Compare April 7, 2026 19:46
The passive-discovery command ran tapirx via docker exec (detached),
leaving a useless PID 1 process and losing all tapirx logs. Tapirx
now starts with correct args via its entrypoint reading env vars.

- Remove passive-discovery exec command
- Add TAPIRX_UPSERT_URL env var to testbed topology
- Add enable-waffle-switch command (required by new BlueFlow)
- Add upsert_url fact
- Add tapirx.local.Dockerfile for building from local source
@t-a-y-l-o-r t-a-y-l-o-r force-pushed the feature/upsert-migration-tests branch from 68f6cb3 to 8c07606 Compare April 7, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant