Run tapirx as PID 1 in discovery scenario#10
Draft
t-a-y-l-o-r wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
647c351 to
68f6cb3
Compare
The passive-discovery command ran tapirx via docker exec (detached), leaving a useless PID 1 process and losing all tapirx logs. Tapirx now starts with correct args via its entrypoint reading env vars. - Remove passive-discovery exec command - Add TAPIRX_UPSERT_URL env var to testbed topology - Add enable-waffle-switch command (required by new BlueFlow) - Add upsert_url fact - Add tapirx.local.Dockerfile for building from local source
68f6cb3 to
8c07606
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passive-discoverydocker exec anti-pattern — tapirx now runs as PID 1 via its entrypointenable-waffle-switchcommand (required by new BlueFlow upsert endpoint)TAPIRX_UPSERT_URLenv var to testbed topologytapirx.local.Dockerfilefor building from local sourceContext
The old scenario ran tapirx via
docker exec(detached) into an already-running container. This meant PID 1 was a useless tapirx process with no API URL, the real worker's logs were lost, and two processes competed for packets on the same interface.Dependencies
Test plan