fix: quadratic scroll speed in smooth scrolling causes enormous jumps#52
Open
karlvr wants to merge 1 commit intovioletlib:masterfrom
Open
fix: quadratic scroll speed in smooth scrolling causes enormous jumps#52karlvr wants to merge 1 commit intovioletlib:masterfrom
karlvr wants to merge 1 commit intovioletlib:masterfrom
Conversation
The smooth scrolling path in getUnitsToScroll() used e.getUnitsToScroll() (which is scrollAmount * wheelRotation) multiplied by e.getPreciseWheelRotation() (which is ~wheelRotation). This squares the wheel rotation, causing scroll distance to grow quadratically with scroll speed rather than linearly. Fix: use e.getScrollAmount() (the per-notch amount, typically 3) instead of e.getUnitsToScroll() so the rotation is only applied once via getPreciseWheelRotation().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smooth scrolling path in
getUnitsToScroll(MouseWheelEvent e, boolean isSmooth)usede.getUnitsToScroll()(which isscrollAmount * wheelRotation) multiplied bye.getPreciseWheelRotation()(which is ~wheelRotation). This squares the wheel rotation, causing scroll distance to grow quadratically with scroll speed rather than linearly.Fix: use
e.getScrollAmount()(the per-notch amount, typically 3) instead ofe.getUnitsToScroll()so the rotation is only applied once viagetPreciseWheelRotation().