Improve thread safety in AquaNativeRendering and close stream in getStringResource()#15
Open
karlvr wants to merge 1 commit intovioletlib:masterfrom
Open
Improve thread safety in AquaNativeRendering and close stream in getStringResource()#15karlvr wants to merge 1 commit intovioletlib:masterfrom
AquaNativeRendering and close stream in getStringResource()#15karlvr wants to merge 1 commit intovioletlib:masterfrom
Conversation
…tringResource() Make createPainter() consistent with the thread-aware synchronized findPainterClasses() by ensuring isInitialized is volatile and is set after preferredPainter. This guarantees correct visibility if createPainter() is ever called from outside the UI thread. Also close the InputStream in getStringResource() using try-with-resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
createPainter()consistent with the thread-aware synchronizedfindPainterClasses()by makingisInitializedvolatile and is set afterpreferredPainter. This guarantees correct visibility ifcreatePainter()is ever called from outside the UI thread.Also close the
InputStreamingetStringResource()using try-with-resources.