Prevent getSliderRenderer w/h side-effects from leaking out of getPainter#14
Open
karlvr wants to merge 1 commit intovioletlib:masterfrom
Open
Prevent getSliderRenderer w/h side-effects from leaking out of getPainter#14karlvr wants to merge 1 commit intovioletlib:masterfrom
getSliderRenderer w/h side-effects from leaking out of getPainter#14karlvr wants to merge 1 commit intovioletlib:masterfrom
Conversation
…nter getSliderRenderer() intentionally modifies the instance w/h fields so that configureLayout() uses the adjusted dimensions for the slider. However, these modified values persisted after getPainter() returned. Save and restore w/h around the call to prevent state leakage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSliderRenderer()intentionally modifies the instance w/h fields so thatconfigureLayout()uses the adjusted dimensions for the slider. However, these modified values persisted aftergetPainter()returned. Save and restore w/h around the call to prevent state leakage.In practice I don't think this creates a problem as
configure(w, h)is always called first, but maybe you'll agree it's nice to tidy up. In this PR: it is a bit weird that the save/restore is in a different method (and class) to the mutation, but it is the best approach I came up with.