Minor bug fixes#13
Open
karlvr wants to merge 4 commits intovioletlib:masterfrom
Open
Conversation
…xelCount Copy-paste error in the opaque pixel count diagnostic message.
…ashCode The thumbExtent field was stored and returned via getThumbExtent() but was not included in equality or hash code checks, so configurations with different thumb extents would compare as equal.
This is a doozy… Arrays.asList() returns a fixed-size list, so addAll() would throw UnsupportedOperationException if extraParameters was ever non-null. When you go to look at the implementation of Arrays.asList and see the new ArrayList… it’s actually an inner class with the same name as the ubiquitous java.util version!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small collection of minor bug fixes in separate commits. The most interesting is the
Arrays.asList, which returns a list backed by the array and so cannot be added to, including a gotcha when you look at the implementation ofArrays.asListand it looks like it uses our friendjava.util.ArrayList!