Clean up process and stream handling in JNRPlatformUtils.command()#12
Open
karlvr wants to merge 1 commit intovioletlib:masterfrom
Open
Clean up process and stream handling in JNRPlatformUtils.command()#12karlvr wants to merge 1 commit intovioletlib:masterfrom
karlvr wants to merge 1 commit intovioletlib:masterfrom
Conversation
Just a cleanup: close the InputStream and destroy the Process. In practice this method is called once at startup for sw_vers which exits immediately, so it is not actually a resource leak. Also replace StringBuffer with StringBuilder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a cleanup: close the
InputStreamand destroy theProcess. In practice this method is called once at startup forsw_verswhich exits immediately, so it is not actually a resource leak. Also replaceStringBufferwithStringBuilder.