fix: vertically center v1.0 version badge in Navbar#449
Open
Xenon010101 wants to merge 1 commit into
Open
Conversation
Remove paddingBottom that offset the v1.0 badge from the flex center and add lineHeight:1 for consistent vertical alignment with the Debugra logo and brand text. Closes vijaypatil477#443
|
@Xenon010101 is attempting to deploy a commit to the omkh4242g-1671's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
quality:clean
|
Hi @Xenon010101, thanks for contributing to Debugra! 🎉 I have automatically:
Our workflows will now analyze your changes to classify:
Tip Ensure your PR description references the issue it resolves (e.g. Happy coding! 🚀 |
github-actions
Bot
added
gssoc:approved
|
@Xenon010101, Great you have made all these changes. |
Author
|
@Vaibhav-221 Good point — will add a screenshot next time. Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the misaligned
v1.0version badge in the navbar. ThepaddingBottom: 1pxon the version span caused it to sit slightly above the vertical center of the navbar, breaking alignment with the Debugra logo icon and brand text.Changes
src/components/Landing/LandingPage.jsx: ReplacedpaddingBottom: '1px'withlineHeight: '1'on the v1.0 version badge span. This lets flexbox'salign-items: centerperfectly center the badge with the adjacent logo and brand name.Before
The
v1.0badge appeared slightly higher than the Debugra logo and text due to the asymmetrical padding.After
The
v1.0badge is now perfectly vertically centered with the logo and brand name in the navbar.Testing
Closes #443