par_sort_pairs: Use a growable pool of thread states#164
Open
progval wants to merge 2 commits intovigna:mainfrom
Open
par_sort_pairs: Use a growable pool of thread states#164progval wants to merge 2 commits intovigna:mainfrom
progval wants to merge 2 commits intovigna:mainfrom
Conversation
It turns out that rayon can return Yield::Idle when there is an other task running the the same thread (lower in the call stack), because it cannot yield to that other task (it would need to jump back to that point of the call stack, then back to where we currently are). This means that we need a way to add new states somehow. Instead of creating throwaway states (which would create many tiny BatchIterators we would have to merge with the others) or making each thread have a pool of throwaway states (which would create fewer of them, but still many because the extra ones can't be used by other states), this introduces a global pool with all states in it. This does add synchronization overhead, but it should be negligeable because try_for_each_init calls this initializer only once per internal sequential iterators; and if there are many small such iterators, then rayon already adds too much overhead anyway.
This would cause us to silently lose data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that rayon can return Yield::Idle when there is an other task running the the same thread (lower in the call stack), because it cannot yield to that other task (it would need to jump back to that point of the call stack, then back to where we currently are). This means that we need a way to add new states somehow.
Instead of creating throwaway states (which would create many tiny BatchIterators we would have to merge with the others) or making each thread have a pool of throwaway states (which would create fewer of them, but still many because the extra ones can't be used by other states), this introduces a global pool with all states in it.
This does add synchronization overhead, but it should be negligeable because try_for_each_init calls this initializer only once per internal sequential iterators; and if there are many small such iterators, then rayon already adds too much overhead anyway.