Skip to content

Use ledger print command instead of journal parsing#7

Open
ikorchynskyi wants to merge 2 commits into
vifon:masterfrom
ikorchynskyi:master
Open

Use ledger print command instead of journal parsing#7
ikorchynskyi wants to merge 2 commits into
vifon:masterfrom
ikorchynskyi:master

Conversation

@ikorchynskyi
Copy link
Copy Markdown

These changes allow to use extended ledger syntax in the base journal, thus indirectly implementing #1. For example, the base journal may look like

include bank1.ledger
include bank2.ledger

and combined journal will be correctly shown on the web interface
Also, I've pinned the fido2 package version to the latest available <1.0 (0.9.3), as it seems that version >=1.0 has changed API and thus incompartible with the current ledger-web codebase.

@vifon
Copy link
Copy Markdown
Owner

vifon commented Jul 11, 2022

Looks like what was hanging on the ledger-print branch for a few months. I was experimenting with this approach, but I'm not quite happy with the loss of the formatting, though it might be a justified sacrifice. I'll probably go with a per-user checkbox in the settings.

Good catch about FIDO2! I was very much experimenting with it when adding this feature and then forgot to pin the version.

I'll address these issues when I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants