fix(ci): run bundle size on stacked prs#1713
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (38)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (32)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (14)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (10)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
mihar-22
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the bundle size workflow to run for stacked pull requests, not only PRs targeting main. The report fix from #1710 already compares against the actual PR base, but stacked PRs were not getting fresh bundle reports because the workflow trigger was limited to main.
Changes
github.base_refand measures it with the PR script.Testing
ruby -e "require 'yaml'; YAML.load_file('.github/workflows/bundle-size.yml'); puts 'valid yaml'"git diff --checkpnpm exec biome check .github/workflows/bundle-size.yml(Biome ignores this path in repo config.)Note
Low Risk
CI trigger-only change with no runtime or application code affected.
Overview
Bundle Size CI now runs on every
pull_request, not only when the base branch ismain.Stacked PRs (base = another feature branch) will get fresh PR/base measurements and the existing bundle-size comment, which already compares against
github.base_ref. Job steps and report logic are unchanged.Reviewed by Cursor Bugbot for commit 3126e97. Bugbot is set up for automated code reviews on this repo. Configure here.