Skip to content

feat(packages): add quality menu UI#1694

Merged
sampotts merged 2 commits into
mainfrom
feat/quality-menu-ui
Jun 17, 2026
Merged

feat(packages): add quality menu UI#1694
sampotts merged 2 commits into
mainfrom
feat/quality-menu-ui

Conversation

@sampotts

@sampotts sampotts commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Stacked PR on top of #1693

Summary

  • Add the UI for quality selection
  • Add icons for quality, speed and captions to the menu (original icons in Figma)
  • Add a badge component to display the bit rate where required
  • Minor styling updates to the menu
  • Tighten up transition timing and reduce exit transition duration
  • Fix issue where the settings menu wouldn't show in Tailwind skins

Screenshots

You can see it in the Sandbox but anyhow:

Default

CleanShot 2026-06-16 at 16 12 19@2x CleanShot 2026-06-16 at 16 12 56@2x

Minimal

CleanShot 2026-06-16 at 16 13 42@2x CleanShot 2026-06-16 at 16 14 12@2x

Note

Medium Risk
Touches playback rendition selection (selectVideoRendition) across many skin entry points; regressions would affect adaptive streaming UX but follow established radio-group patterns with tests.

Overview
Adds video quality selection to the settings menu across HTML custom elements, React presets, and default/minimal skins, wired to existing QualityRadioGroupCore / selectQuality player state.

New media-quality-radio-group / useQualityOptions mirror playback-rate and captions: Auto plus renditions with optional tier (e.g. HD, 4K) and bitrate badges when multiple streams share a resolution. Settings rows gain Quality (with switches icon), plus speed and captions-off icons on Speed/Captions; submenu separators and refreshed menu/popup styling (max height, transitions, badge CSS/Tailwind) apply to all three submenus.

Menu item plumbing extends type="quality" for hint labels (Auto / current rendition) and availability gating so the gear control only appears when at least one setting is available.

Reviewed by Cursor Bugbot for commit 238ed70. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview, Comment Jun 17, 2026 4:06am

Request Review

@sampotts sampotts requested review from luwes and mihar-22 June 16, 2026 06:11

@luwes luwes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mihar-22 mihar-22 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, looks beautiful 🖼️

Base automatically changed from feat/quality-menu to main June 17, 2026 21:20
@sampotts sampotts merged commit 16ab909 into main Jun 17, 2026
19 checks passed
@sampotts sampotts deleted the feat/quality-menu-ui branch June 17, 2026 21:21
@luwes luwes mentioned this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants