feat(packages): add quality menu UI#1694
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2038eb9 to
238ed70
Compare
mihar-22
approved these changes
Jun 17, 2026
mihar-22
left a comment
Member
There was a problem hiding this comment.
great work, looks beautiful 🖼️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR on top of #1693
Summary
Screenshots
You can see it in the Sandbox but anyhow:
Default
Minimal
Note
Medium Risk
Touches playback rendition selection (
selectVideoRendition) across many skin entry points; regressions would affect adaptive streaming UX but follow established radio-group patterns with tests.Overview
Adds video quality selection to the settings menu across HTML custom elements, React presets, and default/minimal skins, wired to existing
QualityRadioGroupCore/selectQualityplayer state.New
media-quality-radio-group/useQualityOptionsmirror playback-rate and captions: Auto plus renditions with optional tier (e.g. HD, 4K) and bitrate badges when multiple streams share a resolution. Settings rows gain Quality (with switches icon), plus speed and captions-off icons on Speed/Captions; submenu separators and refreshed menu/popup styling (max height, transitions, badge CSS/Tailwind) apply to all three submenus.Menu item plumbing extends
type="quality"for hint labels (Auto/ current rendition) and availability gating so the gear control only appears when at least one setting is available.Reviewed by Cursor Bugbot for commit 238ed70. Bugbot is set up for automated code reviews on this repo. Configure here.