Skip to content

[RSDK-13825] Adding warning message for cases where the USB connection speed is not high enough#69

Merged
seanavery merged 1 commit into
viam-modules:mainfrom
SebastianMunozP:improving-log-messages-for-slow-USB-connections
Jun 8, 2026
Merged

[RSDK-13825] Adding warning message for cases where the USB connection speed is not high enough#69
seanavery merged 1 commit into
viam-modules:mainfrom
SebastianMunozP:improving-log-messages-for-slow-USB-connections

Conversation

@SebastianMunozP

Copy link
Copy Markdown
Contributor

No description provided.

@SebastianMunozP SebastianMunozP changed the title Adding warning message for cases where the USB connection speed is not high enough [RSDK-13825] Adding warning message for cases where the USB connection speed is not high enough Apr 24, 2026
@10zingpd 10zingpd requested a review from seanavery May 4, 2026 20:10
@10zingpd

10zingpd commented May 4, 2026

Copy link
Copy Markdown

@seanavery anything to merge here or just close this pr?

@seanavery

Copy link
Copy Markdown
Contributor

@10zingpd Thanks for the bump. Not sure yet, need to give it a review tmrw

@10zingpd

10zingpd commented Jun 8, 2026

Copy link
Copy Markdown

@seanavery were you able to take a look - is it worth even looking at this or should we just close this?

@seanavery seanavery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Locking looks sound, helpful to look up and log if speed is low

@seanavery seanavery merged commit 1897627 into viam-modules:main Jun 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants