Security audit β 2026-06-13#60
Open
versila22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pentest mini-report β versila22/lima-app β 2026-06-13
Probed URL: https://limaimpro.duckdns.org/
Stack: React 18 / Vite / TypeScript / FastAPI (Python) / PWA=yes (vite-plugin-pwa + Workbox)
Counts: Critical=1 High=2 Medium=2 Low=1 Info=1
Findings
backend/app/main.py:48-53package.json(devDep)package.json(devDep)backend/app/utils/security.py:111,120package.jsonpackage.json(devDep)package.json(devDep)Top 3 fixes
_ensure_seed_data()behindAPP_ENV == "development"and remove plaintext passwords from source; rotateadmin@lima-impro.frif it exists in production.npm audit fixto patch vitest, serialize-javascript, and react-router; at minimum upgrade vitest (Critical upstream) and react-router.samesite="none"tosamesite="lax"unless cross-site cookie sharing is explicitly required.Evidence (Critical/High only)
Critical β Hardcoded admin seed credentials
backend/app/main.py:48,lifespancalls_ensure_seed_data()unconditionally at line 133{"email": "admin@lima-impro.fr", ..., "app_role": "admin", "password": "Admin1234!"}APP_ENVguard. On a fresh or wiped DB, createsadmin@lima-impro.fr/Admin1234!and 7 other accounts with known passwords. Source is public on GitHub.if settings.APP_ENV == "development": returnat top of_ensure_seed_data(), remove plaintext passwords from source.High β Vitest UI arbitrary file read/execute (GHSA-5xrq-8626-4rwp)
"vitest": "^2.1.8"β fixed in β₯2.1.9vitest --uiis run in a shared CI/dev environment, arbitrary files on the host can be read and executed.npm install -D vitest@latestHigh β serialize-javascript RCE (GHSA-5c6j-r48x-rmvq)
serialize-javascript <6.0.2npm audit fixVerified safe
innerHTML,dangerouslySetInnerHTML,eval) in React componentslocalStorage/sessionStoragedefault-src 'none', COOP.git/or.env*exposed (all 403)Needs server-side verification
APP_ENV=productionis set on Railwayadmin@lima-impro.frdoes not exist in production DB (or password rotated)Tools
ran=npm-audit, grep-secret-scan, openssl-tls; skipped=DAST-headers (network egress policy blocked outbound HTTP β proxy returned 403
host_not_allowed)Generated by Claude Code