refactor(sdk): build @vercel/sandbox with tsdown dual outputs#84
Open
refactor(sdk): build @vercel/sandbox with tsdown dual outputs#84
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TooTallNate
approved these changes
Mar 10, 2026
Member
TooTallNate
left a comment
TooTallNate
left a comment
There was a problem hiding this comment.
Wanted to point out though that the tsdown configuration in the sandbox package is different (outputs .mjs files). Might want to make that consistent, but up to you.
QuiiBz
approved these changes
Mar 11, 2026
| outExtensions: ({ format }) => ({ | ||
| js: format === "cjs" ? ".cjs" : ".js", | ||
| }), | ||
| unbundle: true, |
Member
There was a problem hiding this comment.
We were already not bundling before due to tsc, but I'm not sure why we're still not bundling here, especially if we ship source maps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vercel/sandboxfrom custom TypeScript dual-build scripts totsdownwith unbundledesm+cjsoutputs./dist/*.jspaths soimportresolves.jsandrequireresolves.cjsimportandrequirebehavior, and include a changeset for the SDK packageValidation
pnpm build(inpackages/vercel-sandbox)pnpm typecheck(inpackages/vercel-sandbox)pnpm test src/package-exports.test.ts(inpackages/vercel-sandbox)