fix(sdk): handle unhandled promise rejections on logs error#82
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Schniz
approved these changes
Mar 10, 2026
Merged
QuiiBz
added a commit
that referenced
this pull request
Mar 10, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## sandbox@2.5.5 ### Patch Changes - Updated dependencies \[[`ac49096ea505d658d6e255780c663765e7a309af`](ac49096)]: - @vercel/sandbox@1.8.1 ## @vercel/sandbox@1.8.1 ### Patch Changes - Fix unhandled promise rejection when running a command while the sandbox is stopping ([#82](#82)) ## sandbox-filesystem-snapshots@0.0.10 ### Patch Changes - Updated dependencies \[[`ac49096ea505d658d6e255780c663765e7a309af`](ac49096)]: - @vercel/sandbox@1.8.1 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tom Lienard <tom.lienrd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a command today might throw an unhandled promise rejection if fetching the logs returns a non-ok status code (e.g. when the sandbox is being stopped)
This happens because
getLogscreates a floating promise without any catch handler.command.logsmay throw an error if the response is not ok, in which case we would get an unhandled promise rejection error. By default in Node.js, this kills the whole process, unless you attach a unhandled promise rejection handler