Open
Conversation
Skip configured validation scripts when not defined in the sandbox's package.json.
gaojude
changed the title
gaojude
force-pushed
the
jude/skip-missing-scripts-codex-provider
branch
from
159cf1a to
4ed561a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the experiment config specifies
scripts: ["build"],runValidationinshared.tsunconditionally runsnpm run buildin the sandbox. If the fixture'spackage.jsondoesn't define that script — or doesn't exist at all, as in evals where the agent scaffolds the project from scratch — this fails and counts as a validation failure even though the missing script isn't the agent's fault.getAvailableScripts()now readspackage.jsonfrom the sandbox and returns the set of defined script names. If the file is missing or invalid, it returns an empty set.runValidationchecks this before running each script and skips any that aren't defined.