fix(windows platform): correct stop/start state checks and add configurable stop timeout#24772
Open
iMithrellas wants to merge 3 commits intovectordotdev:masterfrom
Open
fix(windows platform): correct stop/start state checks and add configurable stop timeout#24772iMithrellas wants to merge 3 commits intovectordotdev:masterfrom
iMithrellas wants to merge 3 commits intovectordotdev:masterfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
… stop and uninstall
23b030f to
0719c4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Windows service control state checks in the
start/stoppaths and improves shutdown behavior.vector service stopwaits until the service reachesStoppedbefore returning.--stop-timeouttovector service stopandvector service uninstallto make shutdown wait duration configurable.Vector configuration
Used standard Windows service installation flow with existing Vector service configuration.
No config schema changes were required for this PR.
How did you test this PR?
cargo fmt --all.vector service stop --stop-timeout <seconds>vector service uninstall --stop-timeout <seconds>Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.Notes
Includes changelog fragment:
changelog.d/windows_service_stop_state_wait.fix.mdImplementation was prepared with LLM assistance; please review carefully.