Skip to content

fix(opentelemetry source): log error #24708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fbs wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −2
Open

fix(opentelemetry source): log error #24708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a68b0aa
fix(source opentelemetry): log error
fbs Feb 22, 2026
798f501
improve error messages
fbs Feb 26, 2026
8ec37d2
add changelog
fbs Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.d/24708_log_error.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The `opentelemetry` source now logs an error if it fails to start up or during runtime.
Copy link
Member

@pront pront Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog filename (add .fix). That should clear the spell checking error as well.

Copy link
Contributor Author

@fbs fbs Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry, fixed

This can happen when the configuration is invalid, for example trying to bind to the wrong
IP or when hitting the open file limit.

author: fbs

Check failure on line 5 in changelog.d/24708_log_error.fix.md

View workflow job for this annotation

GitHub Actions / Check Spelling 

`fbs` is not a recognized word. (unrecognized-spelling)
7 changes: 5 additions & 2 deletions src/sources/opentelemetry/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ impl SourceConfig for OpentelemetryConfig {
cx.shutdown.clone(),
)
.map_err(|error| {
error!(message = "Source future failed.", %error);
error!(message = "OpenTelemetry gRPC source failed. Terminating.", %error);
});

let http_tls_settings = MaybeTlsSettings::from_config(self.http.tls.as_ref(), true)?;
Expand All @@ -257,7 +257,10 @@ impl SourceConfig for OpentelemetryConfig {
filters,
cx.shutdown,
self.http.keepalive.clone(),
);
)
.map_err(|error| {
error!(message = "OpenTelemetry HTTP source failed. Terminating", %error);
});

Ok(join(grpc_source, http_source).map(|_| Ok(())).boxed())
}
Expand Down
Loading