enhancement(codecs): advanced syslog Structured Data & RFC compliance fixes#24662
Open
vparfonov wants to merge 10 commits intovectordotdev:masterfrom
Open
enhancement(codecs): advanced syslog Structured Data & RFC compliance fixes#24662vparfonov wants to merge 10 commits intovectordotdev:masterfrom
vparfonov wants to merge 10 commits intovectordotdev:masterfrom
Conversation
…ve RFC compliance - Support scalars, nested objects and arrays in structured data - Fix UTF-8 safety: use character-based truncation (prevents panics) - Fix RFC 3164: ignore structured data instead of prepending - Add ASCII sanitization for RFC 3164 fields - Add RFC 5424 SD-ID/PARAM-NAME validation
pront
reviewed
Feb 18, 2026
changelog.d/advanced_syslog_sd_rfc_compliance_fixes.enhancement.md
Outdated
Show resolved
Hide resolved
fix SD-ID use char count instead of byte length use workspace dependency for toml changelog with detailed breakdown
Member
|
After the failing checks pass, we can enqueue. I attempted to fix one but I don't have perms to push to this branch. |
pront
reviewed
Feb 26, 2026
auto-merge was automatically disabled
February 26, 2026 18:54
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
February 26, 2026 19:31
Head branch was pushed to by a user without write access
Member
|
You can run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the
syslogencoding transform to support complex structured data (nested objects, arrays, scalars) and improves compliance with RFC 3164 and RFC 5424. It also fixes critical panics related to UTF-8 truncation.Key Changes
1. Structured Data Improvements (RFC 5424)
Previously, the serializer only supported simple key-value pairs in structured data. This PR adds support for:
valueparameter (e.g.,[id value="123"]).{"meta": {"id": 1}}becomes[meta id="1"]).tags="[\"tag1\",\"tag2\",\"tag3\"]").=,],", spaces), replacing invalid chars with_.2. UTF-8 Safety (Panic Fix)
truncate_charshelper ensures we always split on valid character boundaries.3. RFC 3164 Compliance
TAGfield (App Name/Proc ID) in RFC 3164 is now strictly sanitized to ASCII printable characters. Non-ASCII characters are replaced with underscores to prevent protocol violations.rfc = "rfc3164"is selected, rather than emitting malformed headers.Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.