Draft
Conversation
github-actions
bot
added
the
domain: topology
pront
added
the
no-changelog
pront
force-pushed
the
pront-grpc
branch
7 times, most recently
from
a317991 to
45e8d0e
Compare
pront
force-pushed
the
pront-grpc
branch
3 times, most recently
from
d3b8168 to
5cec09b
Compare
pront
force-pushed
the
pront-grpc
branch
2 times, most recently
from
216a7fc to
5b15df1
Compare
8 tasks
8 tasks
The comment now explicitly mentions that Log.metadata_full preserves event metadata during conversion. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Migrate the vector_api integration tests from the deprecated GraphQL API to the new gRPC API. Changes: - Updated test infrastructure to use gRPC client instead of GraphQL - Migrated component queries from GraphQL to gRPC GetComponents RPC - Replaced GraphQL subscriptions with gRPC streaming for tap functionality - Added metrics population in gRPC GetComponents handler to support metrics tests - Fixed config reload tests to work around Vector behavior where components with unchanged names but modified connections don't appear during the reload transition - Increased startup timeout from 2s to 10s to handle slower test environments - Added 500ms delay before polling after SIGHUP to let Vector process the signal Test fixes: - Updated all assertions to use gRPC proto types (ComponentsResponse, ComponentType, etc.) - Changed tap tests to collect events inline instead of storing streams to avoid lifetime issues - Simplified reload tests to completely replace components instead of keeping old names - All 7 tests now pass: tap (4 tests), top (3 tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add breaking change changelog documenting the removal of the GraphQL Playground and replacement with gRPC API. Includes migration guide with grpcurl examples for common operations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
added
the
domain: ci
P0: - Bind TCP listener before spawning to fail fast on port conflicts P1: - Restore fail-fast behavior on API startup failures - Fix tap output format regression (JSON/YAML/logfmt) - Remove metric batching to support <10 components - Fix double throughput normalization P2: - Validate parameters before casting to unsigned types - Report Vector uptime instead of subscription lifetime 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates Vector's internal API from GraphQL to gRPC, significantly reducing code complexity while maintaining backward compatibility for vector top and vector tap commands.
Key Changes
Removed (GraphQL):
Added (gRPC):
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.