enhancement(tag_cardinality_limit transform): Add metric and tag name to tag_value_limit_exceeded_total metric#24236
Conversation
domalessi
left a comment
There was a problem hiding this comment.
A few suggestions but looks good
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
|
btw. Should we add more label? This PR introduces two new tags to an internal metric for the tag_cardinality_limit transform. |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@pront let me know if something is still missing or maybe need to be better handle. |
|
@vectordotdev/vector is there anything that block this PR? Let me know if there is anything to change. |
|
@pront any other concerns about this PR? |
|
Any update? |
|
Hi @vectordotdev/vector, |
08d7446 to
20aa9de
Compare
|
@pront I've followed your sugestions and updated a config param. |
Head branch was pushed to by a user without write access
|
I've updated doc and commited missed test change. |
|
Local check pass:
|
|
@pront sorry to ping you one again, can you rerun the waiting action? |
Head branch was pushed to by a user without write access
|
It looks like run local It's strange because I used command Anyway when I run test locally with: When I ran command locally I've pushed commit and now pipeline should pass |
Summary
When using the
tag_cardinality_limittransform, it's difficult to identify which specific metrics and tag keys are hitting the configured value limit. Thetag_value_limit_exceeded_totalmetric only provides a count of exceeded events without context about which metric or tag was blocked, making it challenging to debug and monitor cardinality issues.More in #20084
This PR adds
metric_nameandtag_keylabels to thetag_value_limit_exceeded_totalmetric and allowing:Vector configuration
How did you test this PR?
Build locally based on docs/DEVELOPING.md and start with config mentioned in the previous section :
Result:
When
internal_metrics.include_extended_tags: false:Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.