feat(webapp): show trade result on signal detail page#122
Draft
itamarreif wants to merge 1 commit intomainfrom
Draft
feat(webapp): show trade result on signal detail page#122itamarreif wants to merge 1 commit intomainfrom
itamarreif wants to merge 1 commit intomainfrom
Conversation
Add a Trade Result card to the signal detail page showing whether the
signal led to a successful, failed-on-slow, or failed-on-fast trade.
- DB: add get_{successful,failed_on_slow,failed_on_fast}_by_signal_id
to TradeRepository (queries by signal FK rather than pair symbols)
- Backend: new GET /trades/by-signal/:signal_id route returning a slim
SignalTradeResultResponse enum (trade_type tag + tx hashes + realized
profit) — omits the embedded signal since the page already has it
- Frontend: add SignalTradeResult type, useTradesBySignal hook, and
TradeResultsCard component with coloured badge + ExplorerLinks
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/signals/:id) showing the outcome of trade execution for that signalGET /trades/by-signal/:signal_idendpoint returns a slim response (no embedded signal) withtrade_typetag + tx hashes + realized profitget_{successful,failed_on_slow,failed_on_fast}_by_signal_id) onTradeRepositoryTokenAmount(USDC)Test plan
🤖 Generated with Claude Code