Makefile: drop python2 support #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behrmann
approved these changes
Nov 9, 2025
Collaborator
behrmann
left a comment
behrmann
left a comment
There was a problem hiding this comment.
Change LGTM.
The error is coming from pytest releasing 9.0 yesterday, which no longer supports Python 3.9
Collaborator
|
Ok, so the workaround is [tool.tox.env.mypy]
description = "Run type checking tool mypy"
# pytest-stub required for type hints to be available
-deps = ["mypy", "pytest-stub"]
+deps = ["mypy", "pytest-stub", "pytest<9.0.0"]
commands = [
["mypy", "--version"],
["mypy", "{posargs:varlink}"]
]in |
jelly
force-pushed
the
drop-makefile-python2
branch
from
ef98ba2 to
799fab7
Compare
pytest 9 requires Python 3.10 or higher.
jelly
force-pushed
the
drop-makefile-python2
branch
from
799fab7 to
902c172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should later drop the whole Makefile I guess.