Support odd Codable behaviors#242
Merged
Merged
Conversation
…nt objects within the same keyed or unkeyed containers. This is not a correct use of Codable, but it is nonetheless a semi-common one.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 76.95% 67.34% -9.62%
==========================================
Files 5 5
Lines 243 297 +54
==========================================
+ Hits 187 200 +13
- Misses 56 97 +41
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.5.2
Currently,
LeafEncoderthrows a fatal error if one attempts to encode more than one object into the same keyed or unkeyed encoding container. Doing so is incorrect use of theCodableAPI, but it is nonetheless a semi-common practice, and is also the only practical way to accomplish some things. This change lifts the restriction and allows such encoding to work as expected.Also bumps the package's Swift version requirement to 6.1 and converts the tests to SwiftTesting.