This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Consolidate Debuggable.stackTrace with the rest of the error types#182
Open
zdnk wants to merge 2 commits intovapor:mainfrom
Open
Consolidate Debuggable.stackTrace with the rest of the error types#182zdnk wants to merge 2 commits intovapor:mainfrom
zdnk wants to merge 2 commits intovapor:mainfrom
Conversation
MrLotU
approved these changes
Mar 4, 2019
Member
MrLotU
left a comment
MrLotU
left a comment
There was a problem hiding this comment.
LGTM! @tanner0101 Could you also check?
tanner0101
suggested changes
Mar 5, 2019
Member
tanner0101
left a comment
tanner0101
left a comment
There was a problem hiding this comment.
This is a breaking change unfortunately. And vapor/core is not a dependency of Vapor 4.
Member
|
Ah. Of course. Something to keep in mind for Vapor 4 in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: vapor/vapor#1804
The
stackTracewas optional and was unreachable by trying casterror: ErrortoDebuggable, it was always returning nil.