Skip to content

fix build #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vansisto merged 1 commit into from
Aug 8, 2025
Merged

fix build #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
release:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [windows-latest, ubuntu-latest, macos-13]

Expand Down
200 changes: 191 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"main": "src/core/electron-main.js",
"description": "Application to encrypt files",
"author": "Van Sisto <vansisto@gmail.com>",
"version": "0.8.1",
"version": "0.8.2",
"scripts": {
"build": "ng build --base-href ./",
"start": "electron .",
Expand Down Expand Up @@ -137,5 +137,8 @@
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.6.2"
},
"optionalDependencies": {
"dmg-license": "^1.0.11"
}
Comment on lines +141 to 143

@coderabbitai coderabbitai Bot Aug 8, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Optional mac-only tooling: good call; verify it’s actually used.

Adding dmg-license as an optional dependency should prevent non-mac builds from breaking. Ensure your electron-builder config specifies a DMG license; otherwise this package won’t be exercised on mac builds.

Run to check if a DMG license is configured:

Optionally consider pinning dmg-license to an exact version to reduce CI variance, unless you rely on upstream patch updates.

🏁 Script executed:

#!/bin/bash
# Look for electron-builder DMG license config in package.json or any config files.
rg -n '"dmg"\s*:\s*{[^}]*"license"' -A3 -U package.json || true
rg -n '"mac"\s*:\s*{[^}]*"dmg"' -A10 -U package.json || true
rg -n '"license"\s*:\s*".*\.rtf"|".*\.txt"' -U

Length of output: 417

🏁 Script executed:

#!/bin/bash
# 1. Check for a DMG license entry in package.json’s build section
jq -r '.build?.mac?.dmg?.license // empty' package.json | sed '/^$/d'

# 2. Search for any .rtf or .txt references in JSON/YAML config files
rg -n '\.rtf' -g '*.json' -g '*.yml' -g '*.yaml' || true
rg -n '\.txt' -g '*.json' -g '*.yml' -g '*.yaml' || true

# 3. Locate electron-builder YAML/JSON config files and look for a "dmg:" block
fd -e yml -e yaml -e json . -x rg -n '"dmg"\s*:' -A3 {} || true

Length of output: 254

🏁 Script executed:

#!/bin/bash
# Search for electron-builder config in JS/TS files for a DMG license entry

# 1. Look for any build.mac.dmg.license references in JS/TS
rg -n 'build\?\.[ ]*mac\?\.[ ]*dmg\?\.[ ]*license' -g '*.ts' -g '*.js' -A3 || true

# 2. Look for any 'dmg' blocks in JS/TS builder configs
rg -n 'mac\?\.[ ]*dmg' -g '*.ts' -g '*.js' -A5 || true

# 3. Look for explicit license file paths (rtf/txt) in JS/TS
rg -n '\.rtf' -g '*.ts' -g '*.js' || true
rg -n '\.txt' -g '*.ts' -g '*.js' || true

Length of output: 7944

Ensure a DMG license is configured for mac builds

It looks like there’s no build.mac.dmg.license entry in your Electron-Builder configuration, so the dmg-license package won’t actually be used on macOS. Please add a reference to your license file (RTF or TXT) under the build.mac.dmg.license key. Also consider pinning the dmg-license version to avoid unexpected CI updates.

– package.json
• Under the build section, add:
json "build": { "mac": { "dmg": { "license": "path/to/your-license.rtf" } } }
– package.json (optionalDependencies)
• Pin to an exact version for stability:
"dmg-license": "1.0.11"

🤖 Prompt for AI Agents 
In package.json around lines 141 to 143, the Electron-Builder config lacks a
build.mac.dmg.license entry, so the dmg-license package is unused on macOS. Add
a "build" section if missing, then under "mac" add "dmg" with a "license" key
pointing to your license file path (RTF or TXT). Also, change the
optionalDependencies entry for dmg-license to pin the version exactly as
"1.0.11" instead of using a caret range to ensure stable CI builds.

}