refactor(install): extract setup core helpers#69
Merged
Conversation
bhdicaire
force-pushed
the
work/install-core
branch
from
090e872 to
09e772b
Compare
bhdicaire
force-pushed
the
work/install-core
branch
from
09e772b to
6928635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request continues the complexity-budget initiative by extracting install/setup normalization logic into a testable functional core.
Detail
This PR:
scripts/lib/install/core.mjsscripts/install.mjsfocused on prompting, filesystem writes, formatting, and verificationtest:install-coreintotest:allnpm run updateChecks
npm run test:install-corenpm run test:installnpm run test:maintenancenpm run checkNotes
This PR does not touch
scripts/workers/or generated Worker runtime files.