Forkless, background iteration utility (forkless)#3553
Conversation
ca38ccc to
206635b
Compare
|
This replaces previous draft version (which was against a different branch). #3432 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forkless #3553 +/- ##
============================================
+ Coverage 76.64% 77.44% +0.79%
============================================
Files 159 161 +2
Lines 79575 82109 +2534
============================================
+ Hits 60994 63590 +2596
+ Misses 18581 18519 -62
🚀 New features to boost your workflow:
|
murphyjacob4
left a comment
There was a problem hiding this comment.
Not a full review - but want to publish some comments to unblock discussion
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as outdated.
This comment was marked as outdated.
prerequisite for threadsave. The real PR for this is being reviewed at #3553 --------- Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
prerequisite for threadsave. The real PR for this is being reviewed at #3553 --------- Signed-off-by: harrylin98 <harrylin980107@gmail.com> Signed-off-by: Jim Brunner <brunnerj@amazon.com> Co-authored-by: Harry Lin <49881386+harrylin98@users.noreply.github.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Just rebasing. The real PR is: #3553 --------- Signed-off-by: harrylin98 <harrylin980107@gmail.com> Signed-off-by: Jim Brunner <brunnerj@amazon.com> Co-authored-by: Harry Lin <49881386+harrylin98@users.noreply.github.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
91a0712 to
b22338f
Compare
|
Status 6/16/2026:
|
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
Signed-off-by: Jim Brunner <brunnerj@amazon.com>
The heart of forkless save (also forkless sync and forkless slot migration) is the bgIteration utility.
bgIteration is responsible for presenting a view of the database, possibly with replication, to achieve the requested consistency.
Important concepts:
The current use case, forkless save, will use a consistent iteration without replication.
Full sync will use a non-consistent iteration, with replication. This allows consistency to be achieved by the end of the syncronization.
There is currently no use case for consistent with replication or non-consistent without replication. However such use cases may be developed in the future. They are fully supported and tested.
Read the documentation in
bgiteration.hfor more details.