Skip to content

Avoid hgetall deferred response#2966

Merged
ranshid merged 4 commits into
valkey-io:unstablefrom
ranshid:avoid-hgetall-deferred-response
Dec 24, 2025
Merged

Avoid hgetall deferred response#2966
ranshid merged 4 commits into
valkey-io:unstablefrom
ranshid:avoid-hgetall-deferred-response

Conversation

@ranshid

@ranshid ranshid commented Dec 23, 2025

Copy link
Copy Markdown
Member

In #2089 we added a deferred logic for HGETALL since we cannot anticipate the size of the output as it may contain expired hash items which should not be included.
As part of the work of #2022 this would greatly increase the time for HGETALL processing, thus we introduce this minor improvement to avoid using deferred reply in case the hash has NO volatile items.

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@codecov

codecov Bot commented Dec 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.81%. Comparing base (992b886) to head (f153374).
⚠️ Report is 5 commits behind head on unstable.

Files with missing lines Patch % Lines
src/t_hash.c 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2966      +/-   ##
============================================
+ Coverage     73.73%   73.81%   +0.07%     
============================================
  Files           125      125              
  Lines         68911    69351     +440     
============================================
+ Hits          50813    51189     +376     
- Misses        18098    18162      +64     
Files with missing lines Coverage Δ
src/t_hash.c 94.50% <90.90%> (-0.14%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/t_hash.c Outdated
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@ranshid ranshid merged commit 75707ac into valkey-io:unstable Dec 24, 2025
36 of 37 checks passed
ranshid added a commit to ranshid/valkey that referenced this pull request Dec 26, 2025
ranshid added a commit to ranshid/valkey that referenced this pull request Dec 26, 2025
This reverts commit 75707ac.

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
ranshid added a commit that referenced this pull request Dec 28, 2025
This is to fix a regression introduced in
#2966.
Example failed run:
https://github.com/valkey-io/valkey/actions/runs/20495981119/job/58895602847

Currently reverting the commit which introduced the regression

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
jdheyburn pushed a commit to jdheyburn/valkey that referenced this pull request Jan 8, 2026
In valkey-io#2089 we added a deferred
logic for HGETALL since we cannot anticipate the size of the output as
it may contain expired hash items which should not be included.
As part of the work of valkey-io#2022
this would greatly increase the time for HGETALL processing, thus we
introduce this minor improvement to avoid using deferred reply in case
the hash has NO volatile items.

---------

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
jdheyburn pushed a commit to jdheyburn/valkey that referenced this pull request Jan 8, 2026
This is to fix a regression introduced in
valkey-io#2966.
Example failed run:
https://github.com/valkey-io/valkey/actions/runs/20495981119/job/58895602847

Currently reverting the commit which introduced the regression

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
In valkey-io#2089 we added a deferred
logic for HGETALL since we cannot anticipate the size of the output as
it may contain expired hash items which should not be included.
As part of the work of valkey-io#2022
this would greatly increase the time for HGETALL processing, thus we
introduce this minor improvement to avoid using deferred reply in case
the hash has NO volatile items.

---------

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
This is to fix a regression introduced in
valkey-io#2966.
Example failed run:
https://github.com/valkey-io/valkey/actions/runs/20495981119/job/58895602847

Currently reverting the commit which introduced the regression

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants