Skip to content

Hash TTL tests - [don't review]#2136

Draft
xbasel wants to merge 34 commits into
valkey-io:unstablefrom
xbasel:ttl_tests
Draft

Hash TTL tests - [don't review]#2136
xbasel wants to merge 34 commits into
valkey-io:unstablefrom
xbasel:ttl_tests

Conversation

@xbasel

@xbasel xbasel commented May 25, 2025

Copy link
Copy Markdown
Member

❌ Don't review, don't merge. ❌

Review this one instead:

ranshid and others added 30 commits May 15, 2025 18:05
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
* add tests

Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>

* fix a bug - return on error

Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>

* disable failing tests

Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>

* rmeove redundant test

Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>

* Update tests/unit/hashexpire.tcl

---------

Signed-off-by: xbasel <103044017+xbasel@users.noreply.github.com>
Co-authored-by: Ran Shidlansik <ranshid@amazon.com>
ranshid added 3 commits May 21, 2025 15:16
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@xbasel xbasel marked this pull request as draft May 25, 2025 07:24
@xbasel xbasel added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label May 25, 2025
@codecov

codecov Bot commented May 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.88889% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.21%. Comparing base (8d686dd) to head (cb45000).
⚠️ Report is 628 commits behind head on unstable.

Files with missing lines Patch % Lines
src/t_hash.c 86.71% 85 Missing ⚠️
src/aof.c 15.78% 16 Missing ⚠️
src/volatile_set.c 66.66% 16 Missing ⚠️
src/expire.c 78.94% 4 Missing ⚠️
src/module.c 0.00% 2 Missing ⚠️
src/rdb.c 92.30% 2 Missing ⚠️
src/hashtable.c 93.75% 1 Missing ⚠️
src/object.c 98.86% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2136      +/-   ##
============================================
- Coverage     71.25%   71.21%   -0.05%     
============================================
  Files           122      123       +1     
  Lines         66026    66737     +711     
============================================
+ Hits          47047    47525     +478     
- Misses        18979    19212     +233     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)
src/db.c 90.05% <100.00%> (+0.06%) ⬆️
src/sds.c 90.05% <100.00%> (ø)
src/server.c 88.09% <100.00%> (+0.05%) ⬆️
src/server.h 100.00% <ø> (ø)
src/t_string.c 95.92% <100.00%> (-0.84%) ⬇️
src/hashtable.c 81.52% <93.75%> (+0.14%) ⬆️
src/object.c 82.89% <98.86%> (+1.54%) ⬆️
src/module.c 9.60% <0.00%> (ø)
src/rdb.c 76.90% <92.30%> (-0.22%) ⬇️
... and 4 more

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants