Add Cluster Mode Enabled (CME) testing support#12
Open
detemmienation wants to merge 2 commits into
Open
Conversation
Signed-off-by: Tracy <yuningt@amazon.com>
Signed-off-by: Tracy <yuningt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements CME (Cluster Mode Enabled) testing support, addressing issue #3.
What's added
Three classes in
src/valkey_test_case.py:ClusterInfo— exposes typed accessors over aCLUSTER INFOreply (is_cluster_ok,cluster_known_nodes,cluster_slots_assigned).ClusterNodeHandle— a single cluster-mode node; wraps the standardCLUSTERcommands (MEET/REPLICATE/ADDSLOTSRANGE) and the waiters for the cluster to converge.ClusterTestCase— orchestrates bootstrap.setup_cluster(num_shards, num_replicas_per_shard)starts the nodes, gossips them together, evenly distributes the 16384 hash slots across primaries, optionally attaches replicas, waits forcluster_state:ok, and returns a topology-awareValkeyClusterclient.Cluster formation is done purely through standard
CLUSTERcommands, and it reuses the framework's existing port reservation, server lifecycle, andnodes.confcleanup.Tests
tests/test_cluster_mode.py:CLUSTER SLOTScovers 0..16383 exactly once, no overlap.