Fixing out of range crash#109
Merged
Merged
Conversation
Signed-off-by: zackcam <zackcam@amazon.com>
roshkhatri
reviewed
Jun 10, 2026
roshkhatri
reviewed
Jun 10, 2026
Signed-off-by: Roshan Khatri <117414976+roshkhatri@users.noreply.github.com>
roshkhatri
approved these changes
Jun 10, 2026
roshkhatri
left a comment
roshkhatri
left a comment
Member
There was a problem hiding this comment.
I think this looks good, the tests we have are the failure cases in the issue so that okay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #105
This fix uses the suggested change of switching to strtod. As this will convert overflows to inf, and not just throw an error. This library still works on subnormal values as well. We do not need an extra check for ERANGE from what I could tell as we are covered by the inf check in
JSONUTIL_ADDITION_OVERFLOWTwo new tests are created the one in dom checks for three different cases, normal + subnormal, subnormal + normal then an overflow check.