Fix for crash when key contains ~#108
Merged
Merged
Conversation
roshkhatri
reviewed
Jun 10, 2026
roshkhatri
left a comment
roshkhatri
left a comment
Member
There was a problem hiding this comment.
change looks goos, just one minor comment
Signed-off-by: zackcam <zackcam@amazon.com>
roshkhatri
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue: #104
Follow RFC 6901 where we set ~ as ~0 to distinguish a regular ~ compared to a ~ created from parsing a /. This fix will set ~ as ~0 for parsing. This will prevent crashes where we originally saw a ~ and expected it to be the start of parsing for a /. We have the order of tilde first so we don't double replace in the loop.
Tests: To make sure this doesnt get changed in the future we have the two scenarios listed in the issues as unit tests now. Without this change the tests would crash causing failures.