Add helm value extraEnvFromSecrets to metrics exporter in order to re…

[dpailer]

…ad the contents of a secret as environment variable in metrics exporter container

e.g. if the secret contains the contents like

REDIS_USER: default
REDIS_PASSWORD: asdfgh

these will be available in a secure way for the redis exporter

[urbaman]

Need this!

[dpailer]

Hi @sgissi and @mk-raven

can you take a look to this PR please and tell me if I need to improve anything?

Currently I am maintaining a fork of the helm-chart with the shown minor additions and this would definitely reduce my maintenance overhead :)

BR

[jessebye]

@dpailer @urbaman it looks like this is already supported?

valkey-helm/valkey/values.yaml

Line 325 in 2f9be3b

# Additional secrets to mount for metrics exporter

disregard - although you can specify extra secrets for the exporter, you can't actually use them since there's no way to reference them in the extraEnvs.

[sgissi]

@dpailer Thanks for the PR, other than proving the user/password to Exporter, is there another use case? The authentication and TLS issues are being worked on other PRs.

[dpailer]

Hi @sgissi
thanks for the feedback
you could pass all kinds of environment variables which are useful for the exporter via secret, not only the user/password. makes it easier to manage the configuration of the exporter e.g. via ExternalSecrets.

[dmaes]

@dpailer why not just a generic {{- with ... }} envFrom: {{- toYaml . | nindent x }} ... ? That way, it supports all possible envFrom values, not just secrets.

(Sorry for low effort code block, typed on mobile)