fix: render auth checksum as annotation#128
Open
beckcl wants to merge 2 commits into
Open
Conversation
beckcl
force-pushed
the
cb-add-secret-checksum
branch
from
7431c47 to
591a3eb
Compare
Add a checksum of the auth secret to the Deployment/Statefulset to ensure a new rollout of Valkey if the auth secret changed. This follows the existing pattern for the init and regular valkey configuration. Signed-off-by: Clemens Beck <mail@beckcl.dev>
beckcl
force-pushed
the
cb-add-secret-checksum
branch
from
591a3eb to
349f174
Compare
sgissi
requested changes
Jan 25, 2026
sgissi
left a comment
sgissi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR, it makes sense. A few comments below.
Signed-off-by: Clemens Beck <mail@beckcl.dev>
beckcl
force-pushed
the
cb-add-secret-checksum
branch
from
19b0aee to
1e86cc2
Compare
Author
|
Thanks for the review @sgissi. I changed the volume mounts and added the missing |
rlunar
added a commit
to rlunar/valkey-k8s-helm
that referenced
this pull request
Apr 5, 2026
…cret change Add checksum/auth-secret annotation to Deployment and StatefulSet pod templates so that password rotations or ACL changes via helm upgrade trigger a rolling restart. Follows the existing pattern used for checksum/initconfig and checksum/config. Also normalizes checksum quoting in the Deployment template to match the StatefulSet. Ref: valkey-io#128
Author
|
Hey @sgissi. Friendly ping on this PR. Please let me know if I can do anything to get this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently changes to the auth secret do not result in a fresh rollout of the Valkey Pods.
We can fix this by rendering an annotation with the secret checksum to the Deployment/StatefulSet similar to what is already being done for ConfigMaps.
This is a common pattern in Helm: https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments