Pull the unstable/main branches of all module repositories for the daily bundle build. #111
Merged
Merged
Conversation
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
roshkhatri
reviewed
May 28, 2026
roshkhatri
left a comment
roshkhatri
left a comment
Member
There was a problem hiding this comment.
Hey Thanks for working on this. I was also looking at this, nice changes
Can you also refer this https://github.com/roshkhatri/valkey-bundle/pull/3/changes for simplification?
Also can you please resolve the conflicts?
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Signed-off-by: Nikhil Manglore <nmanglor@amazon.com>
Member
Author
|
I've updated the PR and resolved the conflicts |
roshkhatri
approved these changes
Jun 8, 2026
roshkhatri
left a comment
roshkhatri
left a comment
Member
There was a problem hiding this comment.
LGTM! THanks for working on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how we create the daily unstable bundle docker build. Originally we took the latest release branches of each of the modules and packaged them with the unstable branch of Valkey. Now we will take the unstable/main branches of each of the module.
To do this I removed the update-unstable job as there is nothing to update anymore pertaining to the unstable build. In versions.json we can hardcode the main branches of each of the repositories and the daily cron will pick it up. We also don't need to update the dockerhub description anymore since we can hard code the unstable branches in each section. Also since this build is meant to be unstable, we won't run any of the integration test cases when releasing the unstable build. We will still run the validation tests to ensure that the container is functional.