Block DRPC until VM DRPolicy has Validated=True and replicationID#16
Merged
mhjacks merged 2 commits intoJun 24, 2026
Merged
Conversation
Extend drcluster-validation (sync-wave 8) to gate DRPC deployment on DRPolicy peer-class replicationID for the virtualization storage class, and document the prerequisite in README and drpc.vmStorageClassName. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
Split the helm-docs comment across two lines to satisfy super-linter's 200-character limit. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drcluster-validationjob (Argo CD sync-wave 8) to block DRPC (sync-wave 10) until the VM DRPolicy isValidated=Trueandstatus.async.peerClassesincludes a non-emptyreplicationIDfor the virtualization storage class.drpc.vmStorageClassName(defaultocs-storagecluster-ceph-rbd-virtualization) and document the VM protection prerequisite in README.Test plan
make test(helm lint + 20 unit tests pass)make helm-docsdrcluster-validation-2m-vmwaits when DRPolicy lacksreplicationID, then succeeds once populatedgitops-vm-protection) applies only after validation job completesdrcluster-validation-2m-novmis unchanged (no VM prerequisite env vars)Made with Cursor